[openstreetmap/openstreetmap-website] Move system test specific sign in to system test superclass (PR #4512)

[Anton Khorev]

Test helper has two methods for login: `sign_in_as` and `session_for`. Which one do you use? The answer is `sign_in_as` in system test and `session_for` everywhere else. Why not then move `sign_in_as` to the system test base class? This class already has other methods and you won't be able to accidentally call `sign_in_as` from non-system tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4512

-- Commit Summary --

  * Move system test specific sign in to system test superclass

-- File Changes --

    M test/application_system_test_case.rb (9)
    M test/test_helper.rb (9)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4512.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4512.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4512
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4512 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240210/459c10e4/attachment.htm>