[openstreetmap/openstreetmap-website] fixed tooltip (PR #4524)

[Tom Hughes]

@tomhughes requested changes on this pull request.



> @@ -2098,7 +2098,7 @@ en-GB:
     site:
       edit_tooltip: Edit the map
       edit_disabled_tooltip: Zoom in to edit the map
-      createnote_tooltip: Add a note to the map
+      createnote_tooltip: Add a note to the map.

Please don't make changes to `en-GB.yml` or any other locale file other than `en.yml` as translations need to be done on Translatewiki not here.

> @@ -3095,7 +3096,7 @@ en:
     site:
       edit_tooltip: Edit the map
       edit_disabled_tooltip: Zoom in to edit the map
-      createnote_tooltip: Add a note to the map
+      createnote_tooltip: Add a note to the map.

This was correct as it was - none of the other tooltips have a full stop.

> @@ -43,6 +43,9 @@
   <fieldset>
     <legend><%= t ".home location" -%></legend>
     <p id="home_message" class="text-muted m-0<% if current_user.home_location? %> invisible<% end %>"><%= t ".no home location" %></p>
+    <p class="text-muted m-0<% if current_user.home_location? %> invisible<% end %>">
+       <b><%= t(".home_location_warning") %></b>

This change will no longer work as you've removed the `home_location_warning` string from the locale file - you were asked to move this to a separate PR which would have required moving both this and the string but instead you just removed the string from this PR and left this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4524#pullrequestreview-1887136570
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4524/review/1887136570 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240218/73d28123/attachment.htm>