[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

[Milan Cvetkovic]

Implements proposal discussed in [Issue 4128](https://github.com/openstreetmap/openstreetmap-website/issues/4128).

- Merge Signup screen and Terms screen during signup process.
- Use links to Contributor terms and Terms of use instead of in-place edit box.
- Terms screen used for accepting the new terms left unchanged.
- Re-arranged signup and login screens to feel like two tabs as in #4128.
- Add `preferred_auth_provider` parameter to signup and login screens, as well as the authorization request.
  This allows 3rd party apps to initiate authorization by adding `preferred_auth_provider`
  
  Screenshots in dev environment:

![image](https://github.com/openstreetmap/openstreetmap-website/assets/99971018/0743bde6-90e6-4bd8-aacc-f9516499024c)
  
![image](https://github.com/openstreetmap/openstreetmap-website/assets/99971018/6547e215-8e15-4e72-bd80-8157b503efa6)

![image](https://github.com/openstreetmap/openstreetmap-website/assets/99971018/6d14af71-5197-40c6-a361-394ab4c087c0)
  
![image](https://github.com/openstreetmap/openstreetmap-website/assets/99971018/ca0b6fcd-b691-4f47-9b9b-44ad256d39d8)

![image](https://github.com/openstreetmap/openstreetmap-website/assets/99971018/82c2263e-f5ef-46c3-ab70-bcf3fdb7cc59)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4455

-- Commit Summary --

  * Merge login and terms screens
  * users_controller: Assume TOU and contirbutor terms are accepted on /user/new form
  * Remove email confirmation field in signup form
  * One column signup, remove .about.paragraph_2
  * Login/Signup tabs, separate page for creating association between 3rd party login and OSM account
  * Remove the globe from /users/new and /users/new_association
  * Add preferred provider to login and signup pages

-- File Changes --

    M .rubocop_todo.yml (2)
    M app/abilities/ability.rb (2)
    A app/assets/javascripts/auth_providers.js (22)
    M app/assets/javascripts/login.js (21)
    M app/assets/stylesheets/common.scss (72)
    M app/controllers/application_controller.rb (2)
    M app/controllers/sessions_controller.rb (3)
    M app/controllers/users_controller.rb (175)
    M app/helpers/user_helper.rb (16)
    M app/models/user.rb (2)
    A app/views/application/_auth_providers.html.erb (38)
    M app/views/sessions/new.html.erb (63)
    M app/views/users/new.html.erb (76)
    A app/views/users/new_association.erb (52)
    M config/locales/en.yml (102)
    M config/routes.rb (2)
    M test/controllers/confirmations_controller_test.rb (29)
    M test/controllers/sessions_controller_test.rb (1)
    M test/controllers/users_controller_test.rb (130)
    M test/integration/user_creation_test.rb (451)
    M test/integration/user_login_test.rb (12)
    M test/system/confirmation_resend_test.rb (5)
    D test/system/user_signup_test.rb (29)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4455.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4455.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240103/9940cd80/attachment-0001.htm>