[openstreetmap/openstreetmap-website] Add system test with osm website oauth app registration (PR #4436)

Tom Hughes notifications at github.com
Sun Jan 7 11:04:10 UTC 2024


@tomhughes commented on this pull request.



>      visit oauth_authorized_applications_path
 
+    accept_alert do
+      click_link "Revoke Access"
+    end

The alternative I was suggesting was to remove the comment after the `create` and replace it with an assertion before the revoke that check there is a single app listed and that it's the web site app - it serves the same purpose as the comment in explaining what the revoke is doing but I think it's clearer and also extends testing of the page to test that it lists authorized apps correctly.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4436#discussion_r1443983866
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4436/review/1807785660 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240107/eb5a9da5/attachment.htm>


More information about the rails-dev mailing list