[openstreetmap/openstreetmap-website] Add system test with osm website oauth app registration (PR #4436)

[Anton Khorev]

@AntonKhorev commented on this pull request.



>      visit oauth_authorized_applications_path
 
+    accept_alert do
+      click_link "Revoke Access"
+    end

> Rather than adding this (and the comment above) all of which took me a few minutes to understand, wouldn't it be simpler just to change the assert below to expect an application?
> This test is just trying to check that the authorized applications page exists and displays rather than the specific contents...

I was asked to test _the specific contents_ of no registered apps: https://github.com/openstreetmap/openstreetmap-website/pull/4434#issuecomment-1869571084. I'm not testing for the website app to be listed here. I'm adapting the already existing test of the message that had a missing translation up until recently to work with the auto-registering website app, which you asked to register for every system test.

> An alternative which would be clearer would be to drop the comment and add an assertion above the revoke to check that the website application is listed and then revoke it and check you get the no apps message?

What is the alternative? I'm revoking the access and checking the message here. Do you want me to revoke it by manipulating models/db then reload the page to check the message?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4436#discussion_r1443981179
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4436/review/1807783193 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240107/e6f820bc/attachment.htm>