[openstreetmap/openstreetmap-website] Changeset page fixes (PR #4463)

[Tom Hughes]

I'm not at all sure I agree with @gravitystorm about the tests... I mean in theory he's right but system tests have a huge cost disadvantage over controller tests and the environment for running them is held together with sticky tape and can fall apart at a moments notice leaving us with degraded tests until we can figure out how to make it work again.

Even if it is the right thing to do in general asserting that the page contains a given piece of text somewhere is in no way equivalent to properly checking the HTML structure as the controller test was doing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4463#issuecomment-1881295907
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4463/c1881295907 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240108/f8455548/attachment.htm>