[openstreetmap/openstreetmap-website] Changeset page fixes (PR #4463)

[Anton Khorev]

- convert changeset comment related tests to system tests because https://github.com/openstreetmap/openstreetmap-website/pull/4313#discussion_r1395452804 and similar tests for notes are also system tests
- shorten changeset page view code, remove unnecessary attributes (`class="notice"`, `class="action-button`, `data-changeset-id`)
- convert comment hide/unhide `<span>`s to buttons, now they can get keyboard focus
- display error message when subscribe fails, similar to https://github.com/openstreetmap/openstreetmap-website/pull/4462
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4463

-- Commit Summary --

  * Test notices of disabled changeset commenting
  * Test changeset commenting
  * Turn hide/unhide comment controls into buttons
  * Remove hidden comments test from controller tests
  * Simplify moderator check when showing changeset comments
  * Remove duplicated code from changeset comments list
  * Show api error message if failed to (un)subscribe
  * Scroll to api error message

-- File Changes --

    M app/assets/javascripts/index/changeset.js (27)
    M app/assets/stylesheets/common.scss (5)
    M app/views/browse/changeset.html.erb (65)
    M test/controllers/browse_controller_test.rb (14)
    D test/integration/user_changeset_comments_test.rb (55)
    A test/system/changeset_comments_test.rb (130)
    M test/test_helper.rb (5)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4463.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4463.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4463
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4463 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240108/7b828856/attachment.htm>