[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

[Milan Cvetkovic]

@milan-cvetkovic commented on this pull request.



> @@ -42,11 +42,32 @@
       <%= f.password_field :pass_crypt, :tabindex => 6 %>
       <%= f.password_field :pass_crypt_confirmation, :tabindex => 7 %>
 
+      <p class="mb-3 text-muted"><%= t(".by_signing_up_html",
+                                       :tou_link => link_to(t("layouts.tou"),
+                                                            "https://wiki.osmfoundation.org/wiki/Terms_of_Use",
+                                                            :target => :new),
+                                       :contributor_terms_link => link_to(t(".contributor_terms"),
+                                                                          t(".contributor_terms_url"),


> Did you make it translatable so the French and Italian versions could be linked to directly for those languages?

This was the idea, similar to how [what's this](https://github.com/openstreetmap/openstreetmap-website/blob/948c1cdfb76ccb6c770ec2bed7001f966d3c5570/app/views/accounts/edit.html.erb#L46C9-L46C113) link next to "Contributor Terms" label in accounts/edit pages is resolved.

> @@ -1,29 +0,0 @@
-require "application_system_test_case"
-
-class UserSignupTest < ApplicationSystemTestCase
-  test "Sign up from login page" do

good point, will bring it back

>      <h4><%= t ".about.header" %></h4>
     <p><%= t ".about.paragraph_1" %></p>
-    <p><%= t ".about.paragraph_2" %></p>

Makes sense - I blindly followed the figma design. Will modify the second paragraph to remove bit about sending the email.

>          # Something is wrong with a new user, so rerender the form
-        render :action => "new"
-      elsif current_user.auth_provider.present?
+        render :action => "new_association"
+      else
         # Verify external authenticator before moving on
         session[:new_user] = current_user.attributes.slice("email", "display_name", "pass_crypt", "consider_pd")
         redirect_to auth_url(current_user.auth_provider, current_user.auth_uid), :status => :temporary_redirect

I was about to ask the same question. Thanks for clarifying what the purpose of the additional round-trip to the provider was about.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444542704
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/review/1808985891 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240109/ff8bc4b5/attachment.htm>