[openstreetmap/openstreetmap-website] Password field is not compared to repeat password field in Signup form (Issue #4474)

[Tom Hughes]

So b1553135fc03e6b4b5f919b98d0fe0e25f37ae10 was the original fix - to preserve the second copy in the hash so that the `before_save` filter could work.

Apparently I then fairly quickly decided to try that alternative approach but I'm not sure if that was because the first one didn't work or I just thought it was better to hash earlier.

The original problem was that the change to storing attributes instead of user records in the sessions in 898a3882c58ed4a1a7e01682052b2078cae7ffd8 had broken password recording for new users because only one copy made it to the filter.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4474#issuecomment-1889522628
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/4474/1889522628 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240112/a802ed85/attachment.htm>