[openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

[Gregory Igelmund]

> @grekko in this pull request chose to reveal the opening comment, both in the web ui and in the api

That is true. The code changes in this PR effectively work around the special handling introduced in https://github.com/openstreetmap/openstreetmap-website/commit/6027c42ee7b5ac6b36e8a62135d2cf67b3ca8250, keeping the Note body of then-deleted users accessible. Thanks for pointing this out.

Just to be explicit: No User-related information would NOT be accessible. The author would be displayed as `anonymous`. Also note comments of deleted Users would continue NOT to be accessible.

AFAIU the current policy of `User#soft_destroy` we would need to keep the information of Note-records by deleted Users hidden. Here a screenshot:

<img width="746" alt="SCR-20240116-qskd" src="https://github.com/openstreetmap/openstreetmap-website/assets/28648/fda8ccf1-3a1f-41ee-87ea-fd93aa97355c">

At this point I think it is useful to clarify if there are good reasons not to continue to comply with the aforementioned policy. If there are none, I can think of the following changes to move forward:

- Notes of deleted users are not hidden per se, but the associated information (body and author) is redacted – effectively hiding the Notes comment. The author is already redacted.
- Associated comments to the Note continue to be accessible (unless their authors are also deleted).

Or alternatively:

- The Note and all of its associated comments are hidden once the original author of the Note is deleted.

Although the latter approach seems rather invasive to other users. I can imagine that Note comments carry a lot of value even though if the message of the initial Note is redacted. Also it seems wrong that a User can effectively manipulate the visibility of other Users comments.

@AntonKhorev Do you think I'm missing here something else?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-1894745472
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4481/c1894745472 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240116/10927033/attachment.htm>