[openstreetmap/openstreetmap-website] Disallow username changes to user_n if n isn't their id (PR #4218)

[Andy Allan]

@AntonKhorev thank you for the PR, that's a good catch. Without it, there's a risk of soft deletes failing.

I changed the code slightly - merging your two commits as @pnorman suggested, and also refactoring slightly to move the change detection to the `validate` statement, to align it with the other validations. I wanted to check that this actually worked (the documentation wasn't 100% clear to me) and by the time I'd checked I figured it was easier for me to commit the code than to ask you to just do the same work!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4218#issuecomment-1898241063
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4218/c1898241063 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240118/f8e08f53/attachment.htm>