[openstreetmap/openstreetmap-website] Refactor login form to use form helpers for password field (PR #4935)

[Anton Khorev]

@AntonKhorev requested changes on this pull request.



> +    <div class="d-flex flex-wrap column-gap-3 justify-content-between align-items-baseline">
+      <%= f.label :password, t(".password"), :class => "my-2" %>

https://github.com/openstreetmap/openstreetmap-website/pull/4935#discussion_r1661380070 talks about the height of the whole row, yet the margin is applied just to the label. Why not:
```suggestion
    <div class="d-flex flex-wrap column-gap-3 justify-content-between align-items-baseline mb-2">
      <%= f.label :password, t(".password") %>
```

Before/after:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/881eed15-8ce8-4e8b-b85e-5838203b6681) ![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/c563252d-4428-483f-8dc2-abe7bcaa1f51)

Also we usually add bottom margin, not both top and bottom.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4935#pullrequestreview-2157925643
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4935/review/2157925643 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240703/ea273a97/attachment.htm>