[openstreetmap/openstreetmap-website] Set "login/signup" page width equal to "about" page width (PR #4954)

Anton Khorev notifications at github.com
Fri Jul 5 11:58:44 UTC 2024


Currently login pages with preferred auth provider look like [this](https://www.openstreetmap.org/login?referer=https%3A%2F%2Fexample.com%2F%3Fpreferred_auth_provider%3Dgoogle):

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/9c45fc8d-9b5f-4ede-b8ae-740c84992796)

The buttons don't fit in one row even on max width. This happens because the page width is still 600px, the logo images were increased to 36px and they are allowed to take only half of the page width.

Now we can remember that 600px is an arbitrary page width (#4773, Page width). It was chosen likely because the standard width is too high for login pages. The other width we use is 760px on [the about page](https://www.openstreetmap.org/about). We can use it for login pages too in exactly the same manner, without special `.auth-container` classes:

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/206461d3-1df1-4b90-815d-a8d0ab778e95)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4954

-- Commit Summary --

  * Set "login/signup" page width equal to "about" page width

-- File Changes --

    M app/assets/stylesheets/common.scss (12)
    M app/views/sessions/new.html.erb (6)
    M app/views/users/blocked.html.erb (6)
    M app/views/users/new.html.erb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4954.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4954.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4954
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4954 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240705/fc87de8a/attachment.htm>


More information about the rails-dev mailing list