[openstreetmap/openstreetmap-website] Check comment ids instead of factory sequence numbers in changeset feed tests (PR #4991)

[Anton Khorev]

I'm not sure what was [that](https://github.com/openstreetmap/openstreetmap-website/pull/4944#discussion_r1665980153) about because comment ids are not inside CDATA or HTML or `<description>`, but rather inside `<link>` or `<guid>`:

![image](https://github.com/user-attachments/assets/fcca9f24-7e00-424c-aee0-c990e93ca972)

The test picked numbers from
https://github.com/openstreetmap/openstreetmap-website/blob/a3441739ca4b70ee634e4e3c29415efe738df52e/test/factories/diary_comments.rb#L3
which happens to also work because if they are descending so do the ids. But it's more complicated because of extra html parsing and more confusing because these numbers are called id yet they are not.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4991

-- Commit Summary --

  * Check comment ids instead of factory sequence numbers in changeset feed tests

-- File Changes --

    M test/controllers/changeset_comments_controller_test.rb (27)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4991.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4991.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4991
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4991 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240715/b43fb358/attachment.htm>