[openstreetmap/openstreetmap-website] Use Auth.providers in auth providers template (PR #5002)

Anton Khorev notifications at github.com
Thu Jul 18 12:54:04 UTC 2024


`_auth_providers.html.erb` iterates over `%w[google facebook microsoft github wikipedia]` and checks which provider is available. But the `Auth` module already does that. `Auth` is only used on account settings pages and has a "provider" "None" specific to these pages. If "None" is removed, `Auth` can be reused in `_auth_providers.html.erb`.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5002

-- Commit Summary --

  * Remove 'None' from auth providers
  * Use Auth.providers in auth providers template

-- File Changes --

    M app/views/accounts/edit.html.erb (2)
    M app/views/application/_auth_providers.html.erb (35)
    M lib/auth.rb (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5002.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5002.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5002
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5002 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240718/0d58edd7/attachment.htm>


More information about the rails-dev mailing list