[openstreetmap/openstreetmap-website] Add Messages API (PR #4605)

Tom Hughes notifications at github.com
Sun Jun 30 10:42:15 UTC 2024


@tomhughes commented on this pull request.



> @@ -78,6 +78,15 @@
       end
     end
 
+    resources :messages, :path => "user/messages", :constraints => { :id => /\d+/ }, :only => [:create, :show, :destroy], :controller => "messages", :as => :api_messages do
+      collection do
+        get "inbox"
+        get "outbox"
+      end
+    end
+
+    post "/user/messages/:id" => "messages#update", :as => :api_message_update

Technically I guess `PATCH` would be the correct thing but as you say it's probably not consistent with the API to date and I haven't managed to find a way to move that route inside the resource block while keeping it as POST unless @gravitystorm has some ideas?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1660148133
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4605/review/2150024135 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240630/79e8e1b6/attachment-0001.htm>


More information about the rails-dev mailing list