[openstreetmap/openstreetmap-website] Add Turbo to replace custom JS (PR #4562)

Gregory Igelmund notifications at github.com
Wed Mar 6 10:16:14 UTC 2024


@grekko commented on this pull request.



> @@ -1,4 +1,4 @@
-<table class="table table-sm align-middle">
+<table class="table table-sm align-middle messages-table">

Personally I'd prefer to use a data-attribute or `js-`-prefixed CSS selector when defining JS-hooks, but I wanted to keep this consistent with other code I read.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4562#pullrequestreview-1919329140
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4562/review/1919329140 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240306/ef1cdf2a/attachment-0001.htm>


More information about the rails-dev mailing list