[openstreetmap/openstreetmap-website] Add Turbo to replace custom JS (PR #4562)

Tom Hughes notifications at github.com
Wed Mar 6 13:36:35 UTC 2024


@tomhughes commented on this pull request.



> @@ -1,36 +1,17 @@
 $(document).ready(function () {
-  $(".inbox-mark-unread").on("ajax:success", function (event, data) {
-    updateHtml(data);
-    updateReadState(this, false);
+  $(".messages-table .inbox-destroy").on("turbo:submit-end", function (event) {

See I have a visceral hatred of doing stuff with raw DOM methods and much prefer jQuery so I suspect that is a separate discussion the project is going to need to have...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4562#discussion_r1514496915
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4562/review/1919783470 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240306/786d3a63/attachment.htm>


More information about the rails-dev mailing list