[openstreetmap/openstreetmap-website] Add Turbo to replace custom JS (PR #4562)

[Gregory Igelmund]

@tomhughes thanks for the quick and helpful feedback.

> a lot of really ugly stuff to handle the transitions 😞

yes, true. I'd like to keep this extra stuff tightly packed together, so we can at least have it not become a remnant at some point in the future. I'll take tomorrow some time to tinker with this a bit.

> Possibly eventually that's something [view transitions](https://turbo.hotwired.dev/handbook/drive#view-transitions) could handle better?

👍🏽

> One thing I'm unclear on is why we're installing turbo with npm when the turbo-rails gem already includes a copy which seems to be the [recommended](https://turbo.hotwired.dev/handbook/installing) way to get it when using rails?

yes. good point. I started initially with just the npm-package because the turbo-rails gem brings a lot of helper code that was not even used in the first draft of the PR and everything works great without the gem. This PR just uses the `meta`-tag helper code from the gem.

Then I figured it would be better to have the gem included since it provides access to even more helper-methods e.g. for Turbo Frames and just forgot to drop the npm-package.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4562#issuecomment-1984301115
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4562/c1984301115 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240307/5ff7c96b/attachment-0001.htm>