[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

[Tom Hughes]

@tomhughes commented on this pull request.

I'll try and have a fuller look later in the week but this is just a couple of things I noticed.

> @@ -750,6 +750,11 @@ tr.turn:hover {
 
   &.new-user-main {
     background-image: image-url("sign-up-illustration.png");
+    background-position-x: 100px;

I would probably make this more like 40-50 pixels - it stops the image being cropped on the right and also means more of it appears with a smallish phone screen.

> @@ -750,6 +750,11 @@ tr.turn:hover {
 
   &.new-user-main {
     background-image: image-url("sign-up-illustration.png");
+    background-position-x: 100px;
+  }
+
+  &.new-user-blocked {
+    background-image: image-url("sign-up-illustration.png");

I started off asking if this also needed the position attribute but found that led me into the fact that the whole `users/blocked` view probably needs to be updated to match the new login/signup layout.

I've added an ACL to block the `blocked.example.com` domain on the test site so you can see what I mean by trying to signup with a `user at blocked.example.com` email.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#pullrequestreview-1927630619
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/review/1927630619 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240311/04d00499/attachment.htm>