[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

Andy Allan notifications at github.com
Wed Mar 13 16:37:32 UTC 2024


> @tomhughes @gravitystorm any more changes required for this PR?

If you can find any way to move parts of this PR into separate PRs, then that would be great. For example, you fixed the blocked page (headings and paragraphs) in the latest commit, but that could be a completely separate PR that can be reviewed separately and merged first. Are there other things like that here?

Perhaps the "login" vs "log in" text changes? The logo change? Or other similar things that can be treated separately? Large pull requests are quadratically hard to deal with - not only is there more to review, but each time I come to re-review the PR, more things have changed, and I need to read and re-read both the changed and also the unchanged parts over and over. So it's really worthwhile to break down the PR into smaller parts, that will ideally only need one maintainer to review and merge.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#issuecomment-1994918240
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/c1994918240 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240313/3119c286/attachment-0001.htm>


More information about the rails-dev mailing list