[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

[Andy Allan]

@gravitystorm commented on this pull request.



> @@ -104,7 +104,7 @@
           <%= link_to t("layouts.logout"), logout_path(:referer => request.fullpath), :method => "post", :class => "geolink dropdown-item" %>
         </div>
       </div>
-    <% else %>
+    <% elsif controller_name != "users" and controller_name != "sessions" %>

This means that if you go to users#show (e.g. visit www.osm.org/user/foo while not logged in) then there is no button to log in or sign up.

If this problem only affects the login and signup pages it needs to be more targetted, either by specific controller methods or moving the signup code into a different controller (e.g. RegistrationsController, to align with Devise). 

Alternatively, perhaps there is a better design solution, since removing these buttons on the full-width layout looks weird and slightly inconsistent to me.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#pullrequestreview-1934699625
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/review/1934699625 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240313/d7cccb12/attachment.htm>