[openstreetmap/openstreetmap-website] Use official "Log in to Microsoft" icon (PR #4580)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> @@ -58,7 +58,11 @@ def openid_logo
 
   def auth_button(name, provider, options = {})
     link_to(
-      image_tag("#{name}.svg", :alt => t("sessions.new.auth_providers.#{name}.alt"), :class => "rounded-3"),
+      image_tag("#{name}.svg",
+                :alt => t("sessions.new.auth_providers.#{name}.alt"),
+                :class => "rounded-3",
+                :width => "36px",
+                :height => "36px"),

`px` shouldn't be in width/height attributes: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#height

You can write `:size => "36x36"` instead: https://api.rubyonrails.org/classes/ActionView/Helpers/AssetTagHelper.html#method-i-image_tag-label-Options

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4580#pullrequestreview-1939197119
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4580/review/1939197119 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240315/63a0dc09/attachment.htm>