[openstreetmap/openstreetmap-website] List of user's changeset comments (PR #4248)

Andy Allan notifications at github.com
Wed Mar 20 17:26:49 UTC 2024


@gravitystorm requested changes on this pull request.



>    ##
   # Get a feed of recent changeset comments
-  def index

As per discussion at https://github.com/openstreetmap/openstreetmap-website/pull/4587 we should avoid creating new controller actions (or renaming existing ones) with non-resourceful names.

> @@ -0,0 +1,27 @@
+module PaginationMethods

I like extracting this to a concern :+1: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1949589767
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4248/review/1949589767 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240320/132dd8ea/attachment.htm>


More information about the rails-dev mailing list