[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

[Milan Cvetkovic]

@milan-cvetkovic commented on this pull request.



> @@ -104,7 +104,7 @@
           <%= link_to t("layouts.logout"), logout_path(:referer => request.fullpath), :method => "post", :class => "geolink dropdown-item" %>
         </div>
       </div>
-    <% else %>
+    <% elsif controller_name != "users" and controller_name != "sessions" %>

@AntonKhorev Interesting. It looks good to me, if we desire to keep the header buttons and tabs at the same time.

@gravitystorm
> Alternatively, perhaps there is a better design solution, since removing these buttons on the full-width layout looks weird and slightly inconsistent to me.

There is a small inconsistency if we keep Login/Signup on the pages along with the tabs under the globe: The login buttons have different referrer:
- login button in adds the referrer to the current page
- login button in the tab keeps the referrer as originally set by initial "login" button that invoked it.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1535447161
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/review/1954585912 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240322/72454c34/attachment.htm>