[openstreetmap/openstreetmap-website] Use "visible" scope when finding traces (PR #4628)

[Tom Hughes]

@tomhughes commented on this pull request.



>  
-    if @trace&.visible? &&
-       (@trace&.public? || @trace&.user == current_user)
+    if @trace&.public? || @trace&.user == current_user

I realise it's not a change from this PR but I don't think we need the conditional dereference here do we? The `find` will have raised an exception if nothing was found...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4628#pullrequestreview-1964028327
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4628/review/1964028327 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240327/ff7c26a4/attachment.htm>