[openstreetmap/openstreetmap-website] Remove tests for message paths without ids (PR #4753)

[Anton Khorev]

Remove tests with "... with no ID should fail ... assert_response :success" and like. They don't do what their comments say and never test missing ids.

Rails is being [smart with path helpers](https://thoughtbot.com/blog/avoid-making-path-helpers-guess) here. It sees that an id is missing and it uses the id from the previous request.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4753

-- Commit Summary --

  * Remove tests for message paths without ids

-- File Changes --

    M test/controllers/messages_controller_test.rb (16)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4753.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4753.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4753
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4753 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240505/7c2c8f59/attachment.htm>