[openstreetmap/openstreetmap-website] OpenID connect icon to SVG (PR #4795)

[Tom Hughes]

@tomhughes requested changes on this pull request.



> @@ -74,7 +74,8 @@ def auth_button_preferred(name, provider, options = {})
       image_tag("#{name}.svg",
                 :alt => t("application.auth_providers.#{name}.alt"),
                 :class => "rounded-1 me-3",
-                :size => "24") + t("application.auth_providers.#{name}.title"),
+                :width => "24px",
+                :height => "24px") + t("application.auth_providers.#{name}.title"),

This was only just changed in b4f719a8c58c5177fe3dbc330fc90b3e0ef94c4c to make it consistent with the `auth_button` method so why are we changing it back again?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4795#pullrequestreview-2056617898
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4795/review/2056617898 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240514/07d49572/attachment.htm>