[openstreetmap/openstreetmap-website] Social sign-in: avoid re-authorization in `users_controller#create` (PR #4847)

Tom Hughes notifications at github.com
Wed May 29 16:49:46 UTC 2024


@tomhughes commented on this pull request.



> @@ -363,7 +307,7 @@ def test_user_create_openid_failure
   end
 
   def test_user_create_openid_redirect
-    auth_uid = "http://localhost:1123/new.tester"
+    auth_uid = "12345654321"

I'm not sure why you're changing this to something that doesn't look like an OpenID id? You didn't change it in the `success` test?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4847#pullrequestreview-2085933360
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4847/review/2085933360 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240529/97215ce8/attachment.htm>


More information about the rails-dev mailing list