[openstreetmap/openstreetmap-website] Social sign-in: avoid re-authorization in `users_controller#create` (PR #4847)

[Milan Cvetkovic]

@milan-cvetkovic commented on this pull request.



> @@ -363,7 +307,7 @@ def test_user_create_openid_failure
   end
 
   def test_user_create_openid_redirect
-    auth_uid = "http://localhost:1123/new.tester"
+    auth_uid = "12345654321"

The reason is to have different values for `auth_uid` and `openid_url`, to be able to verify exactly which one goes where bellow in `assert_redirected_to` and `post "/user/new"`.

I think I should probably update `success` test as well.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4847#discussion_r1619447572
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4847/review/2086410648 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240529/1e98b32c/attachment.htm>