[openstreetmap/openstreetmap-website] Fixed "or divider" issue described in #4773 (PR #4857)
Tom Hughes
notifications at github.com
Wed May 29 16:58:27 UTC 2024
@tomhughes requested changes on this pull request.
This moves the line relative to the `or` text so the line is more or less aligned with the bottom of the text but I think it's better when the line is aligned with the middle of the text? I don't think the old version quite has them perfectly middle aligned but it's certainly a lot closer than this.
> @@ -27,7 +27,7 @@
<%= render :partial => "auth_providers" %>
<div class="d-flex justify-content-center align-items-center">
<div class="border-bottom border-1 flex-grow-1"></div>
- <div class="text-secondary mx-3"><%= t ".or" %></div>
+ <div class="text-secondary mx-3 mb-2"><%= t ".or" %></div>
Was there a reason for choosing the `mb-2` rather than `mb-3` that @gravitystorm suggested?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4857#pullrequestreview-2085952948
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4857/review/2085952948 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240529/0c194a0c/attachment-0001.htm>
More information about the rails-dev
mailing list