[openstreetmap/openstreetmap-website] Make the "remember me" option work as intended (PR #5303)

[Tom Hughes]

The "remember me" checkbox has not been working properly, or rather it has been treated as checked even when it isn't.

The reason is the "Gotcha" details in the [check_box documentation](https://api.rubyonrails.org/classes/ActionView/Helpers/FormBuilder.html#method-i-check_box) which means that the parameter has the value `"0"` when unticked.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5303

-- Commit Summary --

  * Make the "remember me" option work as intended

-- File Changes --

    M app/controllers/sessions_controller.rb (2)
    M test/controllers/sessions_controller_test.rb (18)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5303.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5303.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5303
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5303 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241105/e7159006/attachment.htm>