[openstreetmap/openstreetmap-website] Show "node also part of ways" as nested lists on way pages (PR #5317)
Tom Hughes
notifications at github.com
Wed Nov 13 17:54:58 UTC 2024
@tomhughes commented on this pull request.
I think my main question here is whether we should start these (mostly) expanded or whether they should all be collapsed? Starting them expanded does mean that you're using more vertical space and reducing what top level information can be seen initially?
> @@ -338,9 +338,9 @@ en:
nodes_count:
one: "%{count} node"
other: "%{count} nodes"
- also_part_of_html:
- one: "part of way %{related_ways}"
- other: "part of ways %{related_ways}"
+ also_part_of_ways:
+ one: "also part of %{count} way"
+ other: "also part of %{count} ways"
Should these be `... other way(s)` here? It's not really grammatically correct at the moment given the count exclude one way that the node is a member of.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5317#pullrequestreview-2434039905
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5317/review/2434039905 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241113/87290963/attachment.htm>
More information about the rails-dev
mailing list