[openstreetmap/openstreetmap-website] Use CSS filter instead of dimming tiles (PR #5325)
Anton Khorev
notifications at github.com
Fri Nov 15 14:08:08 UTC 2024
> Additionally, I have made sure that the tiles are not being filtered twice due to inheriting the filter from their parent element. Maybe selecting .leaflet-tile instead of .leaflet-tile-container would solve that problem, too, but I'm assuming that @AntonKhorev had a reason for targeting the container instead.
I wrote all of that months ago and I don't remember what things I did for what reason. `filter` is normally not inherited but Leaflet sets it to `inherit` for tiles. If I target `.leaflet-tile`, that `filter: inherit` overrides my filter declaration, that's probably why I targeted something else without checking if the filter is applied twice. Applying twice wouldn't work for inversion, that's why it got noticed here. But I also had another implementation #4777 with working inversion.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2478943023
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5325/c2478943023 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241115/bd92ecd7/attachment.htm>
More information about the rails-dev
mailing list