[openstreetmap/openstreetmap-website] Use CSS filter instead of dimming tiles (PR #5325)

pkrasicki notifications at github.com
Fri Nov 15 16:38:46 UTC 2024


@pkrasicki commented on this pull request.



> @@ -504,7 +504,13 @@ body.small-nav {
 @include color-mode(dark) {
   .leaflet-tile-container,
   .mapkey-table-entry td:first-child > * {
-    filter: brightness(.8);
+    filter: invert(100%) hue-rotate(180deg) brightness(95%) contrast(90%);

But is it really a big deal? How old would the hardware have to be for this to visibly impact performance? I have no issues with my even longer filter on a 10 years old desktop CPU. So unless you have a specific reason to worry about this, I would ignore that comment.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#discussion_r1844154279
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5325/review/2439127971 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241115/552684a3/attachment.htm>


More information about the rails-dev mailing list