[openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

Anton Khorev notifications at github.com
Sat Nov 16 17:42:52 UTC 2024


@pkrasicki

> The issue here is that the devs have been ignoring our dark map discussion for years

For years nobody could produce viable pull requests implementing dark mode. #2532 and #3028 were overriding *a ton* of css, justifying it with arguments like *osm-website doesn't change much therefore we can afford it* https://github.com/openstreetmap/openstreetmap-website/pull/2532#issuecomment-585434930.

Why would anyone use your invert+rotate filter you've been promoting in #2332 if the entire site doesn't have a dark mode?

>> For example, we got here believers in inverse+rotate. Why do they think that it's the best option?

> I don't think it's the best option, but it's usable. Option 4 would be the best.

Given that 4 is generally not available, you do. But unfortunately it's not as usable for all of the layers.

> My proposal is just an easy to implement temporary workaround that could be used until we get something better.
> There aren't that many layers. It's possible that the filter will be good for a few layers

You'll keep ignoring all of the arguments against invert+rotate and even examples with screenshots. Tracestrack on low zooms doesn't look good even we ignore shadows. The colors are completely off.

> slightly tweaked version of the filter that works best for them

You won't be able to restore shadows by slightly tweaking, unless you mean stop doing invert+rotate.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480681357
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/5328/2480681357 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241116/96d66291/attachment.htm>


More information about the rails-dev mailing list