[openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
Andy Allan
notifications at github.com
Wed Nov 20 11:42:37 UTC 2024
Thanks everyone for your detailed feedback.
As I mentioned [on the forum](https://community.openstreetmap.org/t/openstreetmap-in-dark-mode/119216/30) I have a big conflict of interest here, since I'm both a maintainer of the site, but also a cartographer for some of the map layers. I need to be careful when making decisions which affect other map projects since that could be unfair to them.
However, as both a cartographer and a developer, it also means I have strong opinions on what we should do next!
I think the principle should be that the decision on what each map looks like in dark mode should be **delegated to the cartographers for that map layer**. If they want to make a separate map style, they can do that. If they want to apply a filter, we should offer them that functionality. If they want a specific combination of filters for their own layer, then that's their choice. Or if they want to stick with the exact same map in dark and light mode, then that's their choice too.
We don't control what colours are used on the maps in light mode, and so we shouldn't control those colours in dark mode either.
Call this "Option 4b", which would be:
"Like Option 4, but for map layers without a dark variation, **the cartographers for that map layer** chose a fallback approach, which is then one of options 1,2, or 3."
There are a few drawbacks with this approach. For example, the maintainers of the current default map layer (openstreetmap-carto) have stated that they aren't planning on creating a dark version of their style, and I doubt they will want to use any filters either. And I know that some people really don't want to see a bright map by default when they've asked for dark mode. But I think we have to accept that situation. Perhaps in future, when OWG are considering which maps to feature on the site, they will have some criteria around what the map will look like in dark mode. And maybe in the meantime, if many existing map layers gain dark versions (either through separate cartography or through filters) that will encourage other cartographers to consider the options for their own layer.
If we go with this approach (and let's face it, it's a big **if**, because I think a lot of people will also disagree with me here) then the next steps would be:
* Remove the site-wide filter that's currently applied to all styles.
* Allow the cartographers for each style to either provide a second url, or a list of filters, to apply to their individual map layers in dark mode.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2488361637
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/5328/2488361637 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241120/9cc26912/attachment.htm>
More information about the rails-dev
mailing list