[openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

Gregory Igelmund notifications at github.com
Mon Oct 7 14:49:50 UTC 2024


@grekko commented on this pull request.



> @@ -39,6 +49,10 @@ class Note < ApplicationRecord
 
   DEFAULT_FRESHLY_CLOSED_LIMIT = 7.days
 
+  def comments_with_extra_open_comment

@gravitystorm I've updated the code for the Data-Migration to immediately destroy the first comment as part of the migration and wrapped the whole migration into a transaction.

I have trouble understanding what you are proposing in regards to the logic in the API which needs to prepend the first comment for notes. Could you have a look at my [previous comment](https://github.com/openstreetmap/openstreetmap-website/pull/4481#discussion_r1790139682)?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481#discussion_r1790376242
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4481/review/2352186380 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241007/70b8e82a/attachment.htm>


More information about the rails-dev mailing list