[openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)

[Anton Khorev]

Instead of *submitted* and *commented* note colors switch to *created*, *resolved* and *commented*.

Reasons:
- Close actions were colored as *commented* even if notes were closed without any comments. Now they are going to be colored as *resolved*.
- *Submitted* is not a term we use for notes, we have "add a note" and notes "created by".
- There was a [complaint](https://github.com/openstreetmap/openstreetmap-website/pull/4700#issuecomment-2221682594) about the primary color used for submitted notes that is blue making links harder to see. What other color can we use? For example, the *success* color, like we do for unread messages. But that's the color of the resolved note marker, and then we might as well add the unresolved color.

Caveats:
- I keep "submitted" in locale keys to avoid errors while `subheading_html` is not updated.
- I ignore *reopen* events because if I don't, I'd have to treat them as *open* events but then there wouldn't be an equivalent to the previous *submitted* state. And the equivalent is green *created* + yellow *created and resolved*.
- I had to add this *created and resolved* state because what if the user did both actions? I can't pick one more important color. If I look at note status changes, the latest action is the most important one and I'd have to color notes as *resolved*. But then again I'd lose the equivalent to the previous *submitted* state.

![image](https://github.com/user-attachments/assets/03ac5999-0822-4c03-938d-a8447f3114a4)

Dark mode:
![image](https://github.com/user-attachments/assets/8c88a294-bb1a-42d5-b169-051f68f34916)

Legend while locale strings aren't updated:
![image](https://github.com/user-attachments/assets/754fcbe2-f27d-4103-9359-71932981a56a)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5269

-- Commit Summary --

  * Replace submitted note table color with created/resolved

-- File Changes --

    M app/assets/stylesheets/common.scss (8)
    M app/views/notes/index.html.erb (22)
    M config/locales/en.yml (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5269.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5269.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5269
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5269 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241017/632786e3/attachment.htm>