[openstreetmap/openstreetmap-website] Switch from ubuntu to debian and refactor Dockerfile (PR #5157)
mmd
notifications at github.com
Thu Sep 5 07:58:36 UTC 2024
> I encountered an issue when running tests for the first time inside the Docker container, where some assets were missing. Running bundle exec rake assets:precompile resolved these errors.
I'd suggest to include this info in our readme file: https://github.com/openstreetmap/openstreetmap-website/blob/master/DOCKER.md
> Everything seems to be working fine now, but it would be helpful if a few of us could test this locally before merging.
Same here. I tested on a fresh install. Everything is looking good here.
One thing I don't particularly like about the Dockerfile is that the web container runs everything as root user. We should revisit this topic in another issue. The current Dockerfile has the same issue, and it's unrelated to the switch to Debian.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5157#issuecomment-2330859880
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5157/c2330859880 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240905/89e7ba13/attachment.htm>
More information about the rails-dev
mailing list