[openstreetmap/openstreetmap-website] Home Location page (PR #4926)
David Tsiklauri
notifications at github.com
Fri Sep 6 09:47:24 UTC 2024
Described functionality works perfectly. Redirection is flawless in all situations (browser back/forward button navigation, page refresh, browser link navigation, app menu navigation). Home icon appears in /account/home and disappears as soon as a user is redirected to another page. The only question I have, wouldn't it be better if we used I18n translate function `I18n.t` instead of hard coded text while using `click_on` and `assert_text` in tests. In that case, even if, in the future, we decide to change texts, it won't break tests.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4926#issuecomment-2333685691
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4926/c2333685691 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240906/bc720458/attachment.htm>
More information about the rails-dev
mailing list