[openstreetmap/openstreetmap-website] Home Location page (PR #4926)

Anton Khorev notifications at github.com
Sun Sep 8 08:33:36 UTC 2024


> The only question I have, wouldn't it be better if we used I18n translate function I18n.t instead of hard coded text while using click_on and assert_text in tests. In that case, even if, in the future, we decide to change texts, it won't break tests.

Changing names of i18n strings will break tests then.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4926#issuecomment-2336598204
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4926/c2336598204 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240908/efa8daeb/attachment.htm>


More information about the rails-dev mailing list