[openstreetmap/openstreetmap-website] Send <head> along with pagination frames (PR #5175)

Mon Sep 9 06:26:20 UTC 2024

Things broken by Turbo pagination part 2, the previous part is #5111.

Previous/next page visits are promoted to full page visits with Turbo rewriting most of `<head>` tags. If new tags aren't sent together with the updated frame, old ones will be simply deleted. That includes deleting a page title and csrf token tags, which is going to break some functionality, particularly logouts.

Open any page with Turbo pagination, click *Older/Newer* link, notice that the page title is gone. Then click *Logout* and it's not going to work. https://github.com/openstreetmap/openstreetmap-website/pull/4646#issuecomment-2284931759 worked correctly for changeset elements pagination because it's not promoted to page visits.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5175

-- Commit Summary --

  * Send <head> along with pagination frames

-- File Changes --

    M app/controllers/diary_comments_controller.rb (2)
    M app/controllers/diary_entries_controller.rb (2)
    M app/controllers/issues_controller.rb (2)
    M app/controllers/traces_controller.rb (2)
    M app/controllers/users_controller.rb (2)
    A app/views/layouts/turbo_frame_visit.html.erb (2)
    M test/system/user_logout_test.rb (23)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5175.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5175.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5175 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240908/61a44b09/attachment.htm>