[openstreetmap/openstreetmap-website] Move notification code out of note update transactions (PR #5177)

[Anton Khorev]

We don't need to notify anyone until the transaction is completed. The notification code was inside the transaction since the very beginning in https://github.com/openstreetmap/openstreetmap-website/commit/b3d62bb85a03a0b68068d3d2e7801ec2cd2e3e7b and I don't know why.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5177

-- Commit Summary --

  * Rename comment text from comment to text
  * Move notification code out of note update transactions
  * Move failed responses from test_*_success to test_*_fail
  * Test email notifications when notes are closed and reopened

-- File Changes --

    M app/controllers/api/notes_controller.rb (50)
    M test/controllers/api/notes_controller_test.rb (139)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5177.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5177.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5177
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5177 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240909/12cdaa26/attachment.htm>