[openstreetmap/openstreetmap-website] Move notification code out of note update transactions (PR #5177)

[mmd]

Well, I was commenting on this question:

> The notification code was inside the transaction since the very beginning in ... and I don't know why.

If you keep everything in a single transaction, it's either all or nothing. If you split it up in multiple transactions, creating a comment may succeed, but later on, the notification may still fail independently. Usually, you try to avoid multiple transactions for a single request, because it can cause some inconsistent results.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5177#issuecomment-2338510983
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5177/c2338510983 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240909/223b8923/attachment.htm>