[openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

Tom Hughes notifications at github.com
Fri Sep 13 17:16:24 UTC 2024


@tomhughes requested changes on this pull request.



> @@ -0,0 +1,6 @@
+$(document).ready(function () {
+  $(".language-change-trigger").on("change", function () {

In the interests of ensuring turbo compatibility it's better to write this as:

```
$(document).on("change", ".language-change-trigger", function () {
```

it probably doesn't natter in this case as it's in the header but there's no reason not to be safe in case it ever gets moved.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2303667225
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5201/review/2303667225 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240913/31c32151/attachment.htm>


More information about the rails-dev mailing list