[openstreetmap/openstreetmap-website] More directions refactoring (PR #5901)

[Marwin Hochfelsner]

### Description
I took another look at the directions engines after #5898. I may have found too much, but I kept the commit size low this time.

### How has this been tested?
in chrome and firefox

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5901

-- Commit Summary --

  * Remove TODO fixed in #1439
  * Add instruction index to popup
  * Append all turn-by-turn rows together
  * Remove unused multi-leg logic
  * Remove unneeded coordinate reformatting
  * Split off OSRM getInstructionText function
  * Return OSRM instText individually
  * Derive popup location from lineseg
  * Simplify step mapping function
  * Use shorthand property names

-- File Changes --

    M app/assets/javascripts/index/directions.js (12)
    M app/assets/javascripts/index/directions/fossgis_osrm.js (169)
    M app/assets/javascripts/index/directions/fossgis_valhalla.js (46)
    M app/assets/javascripts/index/directions/graphhopper.js (24)
    M test/system/directions_test.rb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5901.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5901.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5901
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5901 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250406/0bfe6167/attachment.htm>