[openstreetmap/openstreetmap-website] Handle html error message for map xml export (PR #6284)
Tom Hughes
notifications at github.com
Sun Aug 3 14:26:59 UTC 2025
@tomhughes commented on this pull request.
> }
OSM.getTurboBlobHandler = DownloadUtil.getTurboBlobHandler;
+ OSM.getHtmlResponseHandler = DownloadUtil.getHtmlResponseHandler;
I was thinking much the same things when I looked at this, namely why are we defining things in a private class and them immediately exporting them to the global namespace, and why are we using an IIFE for things in the global namespace.
I guess if the class remains private the `getTurboBlobHandler` at least would have to remain in the IIFE even if was moved outside the class as it needs to reference it.
I don't think any of this is a show stopper in any case.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6284#discussion_r2249999654
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6284/review/3082200897 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250803/c6b23c1a/attachment.htm>
More information about the rails-dev
mailing list