[openstreetmap/openstreetmap-website] Add English names to Select Language dialog (PR #6313)

Minh Nguyễn notifications at github.com
Tue Aug 12 07:04:12 UTC 2025


@1ec5 commented on this pull request.



>  - :code: zh-CN
   :native_name: 中文(简体)
+  :english_name: Chinese (Simplified)
 - :code: zh-TW
   :native_name: 中文(繁體)
+  :english_name: Chinese (Traditional)
 - :code: zh-HK
   :native_name: 中文(香港)
+  :english_name: Chinese (Hong Kong)

It’s unusual to have a choice between “Traditional” and “Hong Kong”. I guess Chinese speakers will infer that the “Traditional” option is Taiwanese, but it’s kind of awkward.

> +        <small lang="en" class="english_name d-block text-secondary">
+          <%= language[:english_name] %>
+        </small>

Are we hard-coding English only because most fonts support it, or are there other reasons? Translated language names would be useful to users who want to see the map in a language other than their own, but in that case, we should try to localize the language name into the current language, falling back to English. I think we can assume that the user has an adequate font for the language they currently prefer.

/ref https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2086125665

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6313#pullrequestreview-3108832758
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6313/review/3108832758 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250812/3b9fd060/attachment.htm>


More information about the rails-dev mailing list