[openstreetmap/openstreetmap-website] Update rails-dom-testing to 2.3.0 (PR #6318)

Anton Khorev notifications at github.com
Wed Aug 13 16:00:41 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -32,7 +32,7 @@ def test_changeset_details
     changeset_details_dom = Rails::Dom::Testing.html_document_fragment.parse "<div>#{changeset_details(changeset)}</div>"
     assert_dom changeset_details_dom, ":root", :text => /^Closed .* by #{changeset.user.display_name}$/ do
       assert_dom "> time", :count => 1 do
-        assert_dom "> @title", "Created: Mon, 01 Jan 2007 00:00:00 +0000\nClosed: Tue, 02 Jan 2007 00:00:00 +0000"
+        assert_dom "> @title", "Created: Mon, 01 Jan 2007 00:00:00 +0000 Closed: Tue, 02 Jan 2007 00:00:00 +0000"

Don't we want to test for newline here?

```suggestion
        assert_dom "> @title", :html => "Created: Mon, 01 Jan 2007 00:00:00 +0000\nClosed: Tue, 02 Jan 2007 00:00:00 +0000"
```

This works in both versions of rails-dom-testing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6318#pullrequestreview-3116661519
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6318/review/3116661519 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250813/c5493f2b/attachment.htm>


More information about the rails-dev mailing list